Skip to content

ref(browser): Reduce bundle size of GlobalHandlers integration #14555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

ref(browser): Reduce bundle size of GlobalHandlers integration #14555

wants to merge 2 commits into from

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Dec 3, 2024 •
edited
Loading

Just a slight reduction but while reviewing #14546 I figured this might shave off a couple of bytes. Let's see...

@Lms24 Lms24 marked this pull request as draft December 3, 2024 15:19
@Lms24 Lms24 self-assigned this Dec 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 23.09 KB -0.13% -30 B 🔽
@sentry/browser - with treeshaking flags 21.82 KB -0.13% -28 B 🔽
@sentry/browser (incl. Tracing) 35.58 KB -0.07% -23 B 🔽
@sentry/browser (incl. Tracing, Replay) 72.46 KB -0.03% -19 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.95 KB -0.04% -24 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 76.78 KB -0.03% -18 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 89.27 KB -0.02% -16 B 🔽
@sentry/browser (incl. Feedback) 39.85 KB -0.07% -26 B 🔽
@sentry/browser (incl. sendFeedback) 27.72 KB -0.09% -23 B 🔽
@sentry/browser (incl. FeedbackAsync) 32.53 KB -0.08% -24 B 🔽
@sentry/react 25.78 KB -0.13% -34 B 🔽
@sentry/react (incl. Tracing) 38.46 KB -0.08% -31 B 🔽
@sentry/vue 27.24 KB -0.09% -23 B 🔽
@sentry/vue (incl. Tracing) 37.38 KB -0.05% -18 B 🔽
@sentry/svelte 23.25 KB -0.1% -22 B 🔽
CDN Bundle 24.29 KB -0.13% -32 B 🔽
CDN Bundle (incl. Tracing) 37.27 KB -0.08% -28 B 🔽
CDN Bundle (incl. Tracing, Replay) 72.14 KB -0.04% -25 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 77.48 KB -0.04% -31 B 🔽
CDN Bundle - uncompressed 71.39 KB -0.09% -61 B 🔽
CDN Bundle (incl. Tracing) - uncompressed 110.67 KB -0.06% -61 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 223.74 KB -0.03% -61 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 236.96 KB -0.03% -61 B 🔽
@sentry/nextjs (client) 38.76 KB -0.07% -27 B 🔽
@sentry/sveltekit (client) 36.13 KB -0.06% -20 B 🔽
@sentry/node 134.83 KB +0.01% +1 B 🔺
@sentry/node - without tracing 96.84 KB +0.01% +1 B 🔺
@sentry/aws-serverless 109.17 KB - -

View base workflow run

@codecov Codecov
Copy link

codecov bot commented Dec 3, 2024 •
edited
Loading

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
592 3 589 28
View the top 3 failed tests by shortest run time 
public-api/instrumentation/onError/thrown-strings/test.ts should catch thrown strings
Stack Traces | 0.269s run time 
test.ts:7:11 should catch thrown strings
public-api/instrumentation/onError/non-string-arg/test.ts should catch onerror calls with non-string first argument gracefully
Stack Traces | 0.278s run time 
test.ts:7:11 should catch onerror calls with non-string first argument gracefully
public-api/instrumentation/onError/thrown-objects/test.ts should catch thrown objects
Stack Traces | 1.47s run time 
test.ts:7:11 should catch thrown objects

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@Lms24
Copy link
Member Author

Lms24 commented Dec 3, 2024

Nevermind, I missed an important detail which makes my change no longer equal. Closing...

@Lms24 Lms24 closed this Dec 3, 2024
@Lms24 Lms24 deleted the lms/ref-reduce-bundlesize-globalHandlers branch December 3, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Lms24 Lms24

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Lms24